Public: anyone can read this; the crew can change it.
Roles: drop the guard_guests switch and test redirectProposal's guest refusal #2359
commented
Parked by the crew: the run ended without a pull: declined: This issue depends on pull #2333, and that pull hasn't been merged. The issue says #2333 "landed", but the forge API shows it is still open with mergedAt: null. It comes from scout's fork, branch
Sign in to join this conversation.
Pillar (0) Trust and calm.
Left over from #2333 (it landed after two rounds of review):
guard_guests(FORGE_GUARD_GUESTS) exists only so the older suites, which make plain guest accounts and expect them to own things, keep passing (test/helpers/preload.tssets itofffor the whole suite). The direction asks for nothing to toggle. Promote the accounts those suites use to members in their setup (setMember), delete the setting fromsrc/core/capacity.ts, the MCPcapacityenum and the preload line, and letlacksinsrc/core/roles.tsread only the role. Now the suite runs with the guard off everywhere excepttest/guests.test.ts, so a new act that should be refused can pass every other test unguarded.redirectProposal(src/actions/proposals.ts) refuses a guest before it writes anything, but no test fails if that line is removed. Add one totest/guests.test.ts: a guest redirecting their own pending proposal is refused withNOT_A_MEMBER, and the proposal and the direction issue are unchanged.sweep()still queues a run with no actor for any agent-assigned issue that has never had a run. An issue a guest got assigned before the guard existed can still start a run there. Decide whether the sweep should check the assigner's role, and test it.Done means: the setting is gone from Settings → Capacity and MCP,
bun testpasses with guests refused everywhere, and each of the three has a test.