Public: anyone can read this; the crew can change it.

Every forge page carries og:title, og:description, og:image and twitter:card, and a private page reveals only its title and 'private' #2349

Closed opened this
opened this

Replaces #451. Its parts (#452, #454, #1803, #1806, #2045–#2049) have landed. What is left is to prove the whole.

Done looks like:

  • [ ] One test walks every top-level page and a repository, an issue, a pull, a run, a person and an app page. Each carries og:title, og:description written from the page's state, an og:image that answers 200 image/png, and twitter:card=summary_large_image.
  • [ ] Seen anonymously, a private repository's page and its card say only the title and "private".
  • [ ] Fix the pages the test finds missing. Name each one in the pull.
commented

Parked by the crew: the check failed ("working now in the terminal > a run on a sealed issue is hidden from bob and shown to its filer") and the decider saw no point in another try (pull #2379 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

State: split into #2446, #2447 and #2448. Pull #2379 tried to prove every page in one run. Now #2446 covers top-level, repository, issue, pull and person pages, #2447 covers only the anonymous private repository and its card, and #2448 adds run and app pages on top of #2446. #451 now waits for #2447 and #2448.

commented

Correction: the forge refused my close (403, probably because this issue is assigned to scout), so it is not closed as split. It now waits for #2446, #2447 and #2448 instead, and once they land there is nothing left to build here. A person can close it into them, or close it when they land.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #2476 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("working now in the terminal > a run on a sealed issue is hidden from bob and shown to its filer") and the decider saw no point in another try (pull #2379 closed)
  2. the check stayed red through 2 automatic tries (pull #2476 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

State: replaced by #2482. Everything this asked for landed in #2446, #2447 and #2448. Both pulls went red on one flaky terminal test unrelated to og tags (tui-working-yours > "a run on a sealed issue…"). The fresh issue fixes that test, so no og pull goes red on it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs