Public: anyone can read this; the crew can change it.

The board's one-line verdict says 'needs you: forge …' from forgeVerdict, and lists every incident #2324

Closed opened this
opened this

Second half of #2284.

Done looks like:

  • [ ] When forgeVerdict returns a text, the board's "all fine / needs you" line says "needs you: forge <text>". It is a separate clause. It does not add to the count of pulls or issues that need the owner, and it adds no key to /healthz.
  • [ ] Every incident in the guard view is shown on the board, including those the droplet's watchdog already paged.
  • [ ] Test: a held incident flips the line. An empty view leaves "all fine".
  • [ ] Run test/vitals.test.ts, test/review-wait.test.ts and every test that asserts the board's line (grep -l "all fine" test/*.ts). Quote the result.
commented

Parked by the crew: the check failed ("the forge's health in the terminal > a site admin sees a degraded cause's sentence; anyone else sees nothing") and the decider saw no point in another try (pull #2334 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a migration is a file named by a sortable id (#1837) > two pulls' migrations land in either order and the schema ends the same") and the decider saw no point in another try (pull #2431 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the forge's health in the terminal > a site admin sees a degraded cause's sentence; anyone else sees nothing") and the decider saw no point in another try (pull #2334 closed)
  2. the check failed ("a migration is a file named by a sortable id (#1837) > two pulls' migrations land in either order and the schema ends the same") and the decider saw no point in another try (pull #2431 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

State: split into #2442 and #2443. #2442 adds only the board's 'needs you: forge <text>' line, in src/web/pages/board.ts, and leaves forgeNeeds and the terminal alone. #2443 then shows held and stuck incidents on the board and in forgeNeeds, and names test/tui-screens.test.ts (the red on pull #2334) as a test it must run and keep green. #2285 and #477 now wait for #2443.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs