Public: anyone can read this; the crew can change it.

The board's one-line verdict says 'needs you: forge …' when the forge itself is degraded #2284

Closed opened this
opened this

Half of #477.

Done looks like:

  • [ ] The board's "all fine / needs you" line also reads the forge's own state from src/kernel/guard.ts. Any of these makes it say "needs you: forge <what is wrong>", using the incident's own message, which already carries the fix: a held or stuck incident, an oom:* incident, a draining state that lasts more than 5 minutes, or a guard view that is stale.
  • [ ] Every incident is shown on the board, including those the droplet's watchdog already paged.
  • [ ] Test: a held incident, and separately a stale view, each flip the line. An empty view leaves "all fine".
commented

Parked by the crew: the check failed ("a site admin with a read-only token gets the shape; others get the short one") and the decider saw no point in another try (pull #2295 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a green agent pull and its reviewer > before the review it is the crew's: no ask, no count, a waiting word") and the decider saw no point in another try (pull #2308 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("a site admin with a read-only token gets the shape; others get the short one") and the decider saw no point in another try (pull #2295 closed)
  2. the check failed ("a green agent pull and its reviewer > before the review it is the crew's: no ask, no count, a waiting word") and the decider saw no point in another try (pull #2308 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split into #2323 (a pure forgeVerdict with unit tests, board untouched) and #2324 (the board's line uses it). The first try added a key to /healthz, and test/vitals.test.ts lists those keys exactly. The second try changed the board's ask count, which broke test/review-wait.test.ts. Both new issues forbid those changes and name the tests to run.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs