Public: anyone can read this; the crew can change it.
On a one-writer forge, the writer lets a proposed pull's exact head run, and that grant never counts as a review #2220
commented
Closed: already done on main in 261d63d3 (pull #2223).
Sign in to join this conversation.
For the owner who is the only writer on their forge: a pull a child forge proposed upstream must get its check and preview without the owner faking a review. Replaces #2212. #2212 was declined twice because #2182 was not on main yet. It now is (release 0.7.147, 8bb4d2b4).
Where it stands on main:
pullMayRun(src/core/pull_trust.ts:30) treats a pull as proposed when its head branch starts withchild/orpullProposalOf(db, pull.id)finds it.approveHere(src/actions/pulls.ts:708) returnsnot_foreignwhenoriginHeadRepois null (line 719) andself_reviewfor the minter (line 722). So nobody on a one-writer forge can let a proposal run.Done looks like:
pullMayRun(db, repo, pull, thatOid)is true. Use one action insrc/actions/pulls.tsthat every door calls; extendapproveHerefor proposed pulls or add a sibling.require_reviewor the merge gate. Test: in arequire_reviewrepo, the minter lets a proposal pull run, its check runs, and the pull is still not mergeable until someone else approves.approveHereCardinsrc/web/pages/pull.ts), the terminal pull screen'sA(src/tui/screens/pull.ts), the API route beside the existing approve-here route insrc/http/api.ts, and MCP if approve-here is an MCP tool today.test/proposal-token.test.tsor a newtest/proposal-run.test.ts.bun x tsc --noEmitpasses.Risks: do not loosen
pullMayRunfor ordinary foreign pulls. Only the proposed branch of the function changes.