Public: anyone can read this; the crew can change it.

Flaky: test/revert.test.ts #2112

shipped production is serving it opened this has it
opened this

test/revert.test.ts is red in 8 of 10 runs of bun scripts/flake-hunt.ts admit test/revert.test.ts (random order, under load), so #261 could not admit it to the gate. It stays in EXCLUDED in scripts/gate.ts under this issue.

The seeds reproduce exactly without load, so this is an order dependency inside the file: a test relies on state that an earlier test leaves behind, or a later test breaks state that an earlier one set up. It is not a timing race.

Tests seen failing:

  • take it back: reverting a shipped change, headless > a change already taken back is refused rather than reverted twice
  • take it back: reverting a shipped change, headless > a test fails on today's code: ship it, take it back, main only changes once the revert lands

First failure:

error: expect(received).toBe(expected)

  "alpha
+ DELTA

Red seeds: 3318361365, 1496164636, 3729751601, 3945355459, 2163115238, 1444980411, 1783690143, 3675721586. Reproduce: bun test --randomize --seed=3318361365 ./test/revert.test.ts.

Done looks like

  • [ ] Each test in the file sets up what it reads, so the file is green in any order. Do not add retries, and do not weaken an assertion.
  • [ ] bun scripts/flake-hunt.ts admit test/revert.test.ts is 10/10 green, and its record is in the pull.
  • [ ] The file's row moves from EXCLUDED to GATE in scripts/gate.ts in the same pull.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs