Public: anyone can read this; the crew can change it.

Flaky: test/reviews-states.test.ts #2107

shipped production is serving it opened this has it
opened this

test/reviews-states.test.ts is red in 5 of 10 runs of bun scripts/flake-hunt.ts admit test/reviews-states.test.ts (random order, under load), so #261 could not admit it to the gate. It stays in EXCLUDED in scripts/gate.ts under this issue.

The seeds reproduce exactly without load, so this is an order dependency inside the file: a test relies on state that an earlier test leaves behind, or a later test breaks state that an earlier one set up. It is not a timing race.

Tests seen failing:

  • review states, and the merge they gate > every verdict and resolution reaches the event outbox

First failure:

error: expect(received).toContain(expected)

Expected to contain: "pull.thread_resolved"
Received: [

Red seeds: 394420590, 1239803461, 486729819, 158412525, 4160762648. Reproduce: bun test --randomize --seed=394420590 ./test/reviews-states.test.ts.

Done looks like

  • [ ] Each test in the file sets up what it reads, so the file is green in any order. Do not add retries, and do not weaken an assertion.
  • [ ] bun scripts/flake-hunt.ts admit test/reviews-states.test.ts is 10/10 green, and its record is in the pull.
  • [ ] The file's row moves from EXCLUDED to GATE in scripts/gate.ts in the same pull.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs