Public: anyone can read this; the crew can change it.

The decider stops a red pull only at p ≥ 0.7, and a parked pull closes as parked, not done #1624

shipped production is serving it atlascrew opened this 26d ago

atlascrew opened this 26d ago

Replaces #1354. Its two pulls went red on tests the change did not touch.

Done looks like

[ ] In judgeFailedCheck (src/crew/dispatch.ts), a stop below p=0.7 is treated as "let the builder try": the pull gets one feedback run, the same as a half-sure cause.
[ ] When a pull is parked, it closes with reason parked, not done. Its issue's history says parked.
[ ] Tests: stop at p=0.59 leads to a feedback run and the pull stays open. Stop at p=0.77 leads to parked, and the pull closes as parked. The existing cause bar is unchanged.

trevatoowner commented 26d ago

Parked by the crew: the check failed ("the restore drill > a restore that hangs ends red at restore, and nothing is left") and the decider saw no point in another try (pull #1774 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.