Public: anyone can read this; the crew can change it.

Ship and close from the inbox and the feed land back on the same page with a one-line flash #1567

shipped production is serving it opened this has it
opened this

Replaces #1110, narrowed to what is not on main yet. src/web/studio/actions.ts already has flashTo(ctx, back, …) for tells; read it first.

Done looks like:

  • [ ] POST …/pulls/:number/ship and …/state (close) taken from the home inbox or the feed carry a back field (a same-origin path, validated: anything else falls back to the pull page) and redirect there with a flash: "Shipped #N · see it live" with the one link.
  • [ ] Taken from the pull page they stay on the pull page.
  • [ ] Tests in the existing studio test file (not a new file, or add it to GATE in scripts/gate.ts): ship from the home returns to the home; a back of https://evil.example/ lands on the pull page.

The say, review-state and asks' decide routes, and in-place fragment re-render, come after this lands.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs