Public: anyone can read this; the crew can change it.

A run that declines or fails after its pull opened early closes that pull with the reason #1462

shipped production is serving it opened this has it
opened this

Part of #1049. Pull #1403 went red on exactly this case: "a decline after an early pull closes it with a reason".

Done looks like

  • [ ] When a run whose pull opened early ends in DECLINED:, the pull is closed and its body or a comment carries the decline sentence verbatim.
  • [ ] When the run ends with no new work, or in an error, the pull is closed with one sentence that says so and links the run.
  • [ ] One test in test/crew.test.ts covers each of the two cases, and the pull quotes them run in the sandbox.
  • [ ] Every new test/*.test.ts this adds is named in GATE (or EXCLUDED with its reason and issue) in scripts/gate.ts in the same commit, and bun test test/check-list.test.ts passes before the push.
  • [ ] Before pushing, run bun x tsc --noEmit and the test files this touches (the sandbox sets FORGE_TEST_SOCKET, so the server suites run there), and quote both results in the pull.

Files: src/crew/runner.ts, src/crew/early.ts, test/crew.test.ts. Risk: never close a pull a person has commented on or approved. Leave that one open with a comment. Builder: mason.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs