Public: anyone can read this; the crew can change it.

A green change's card on the asks page says "its tests passed" every time, not "its check passed" when another run sorts first #14406

shipped production is serving it opened this has it

Landed in pull #14407 · run

opened this

Evidence: test/asks.test.ts "a green change's card says what its tests did" failed in the full suite (check run 01m7tt6wg5j4sc3kpz97xvqar4, shard 2077, 4 at a time) and passes alone. The card read: bot finished "Bot clause" and the check is green (its check passed). instead of its tests passed, so the card picked a run other than the finished deploy run with TESTS_PASSED_TAIL, most likely an order that ties on a timestamp.

Done looks like:

Files: the decisions/asks module that builds says (decisionsFor), test/asks.test.ts. Risk: none beyond the wording of one card.

commented

Reviewed pull #14407 at its head: ticked The card chooses its run by a total order (time, then id), and the run whose summary carries the test tail wins when both are green.; A test creates two runs in the same millisecond and asserts the card says its tests passed.; test/asks.test.ts passes with --rerun-each 20..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs