Public: anyone can read this; the crew can change it.

A cancelled run ends its whole process tree: a test starts a run whose child spawns a grandchild, cancels it, and finds neither alive #14275

shipped production is serving it opened this has it

Landed in pull #14284 · run

opened this

Trust names it: a cancelled run ends its processes. src/runs/stoppable.ts exists; nothing proves a grandchild dies with its parent.

Done when

Files I expect to change: src/runs/stoppable.ts, src/runs/grace.ts, test/

Risks: the sandbox forbids signalling processes of an earlier command; keep the fixture inside one run

Suggested brief: mason. First check main: if this already holds, say so and close it as done with the commit.

commented

Reviewed pull #14284 at its head: ticked A test fixture runs a command that backgrounds a long sleep, cancels the run, and asserts both pids are gone within the grace period; If one survives, the stop signals the process group and the test passes; Runs that end normally are untouched; The result is recorded on the run as ended: cancelled with the pids it killed.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs