Public: anyone can read this; the crew can change it.

/status and /api/v1/health name the same running commit #14220

Closed opened this has it

Landed in pull #14224 · 2 runs · run

opened this

Intent: "what is running" has one answer, so an owner can tell whether production caught up with main.

Evidence (production, 2026-11-16 13:49 UTC, same minute): GET /api/v1/health answered "commit":"2af6df6c2f91a583d1c547552168895a93bafe6d","version":"dev" and GET /status (JSON) answered "commit":"83079e5cb88b3d807add01e930152af9ffe3a2e9","version":null. The status page reads the release record (runningFields in src/web/pages/status.ts); health reads something else.

Done when:

Files: src/web/pages/status.ts, src/actions/health.ts (or wherever /api/v1/health builds its commit), one test file

Risks: production-behind-main alarms (#11507's work) read one of these; keep their source and make the other follow it, never the reverse without checking.

3 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: on main, /status and /api/v1/health already get the running commit and version from the same function, so there's no split to fix and no test that could fail on main. The mismatch in the evidence

commented

Reviewed pull #14224 at its head: ticked proven on production: the two answers match. left open: both answers read one function for the running commit and version (the release record when present, the build stamp otherwise), named once in src/core — The shared function exists in src/kernel/version.ts (running()), not src/core, and it reads no release record; left unmoved by choice.; a test starts the app with a known stamp and asserts /status JSON and /api/v1/health carry the same commit; it fails on main — The test exists and is right, but it passes on main, so the fails-on-main clause is not met..

commented

Left open after pull #14224 landed: 2 unticked items remain (both answers read one function for the running commit and version (the release record when present, the build stamp otherwise), named once in src/core; a test starts the app with a known stamp and asserts /status JSON and /api/v1/health carry the same commit; it fails on main). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Both boxes are met on main in cba9ab04a (#14224): test/status-page.test.ts sets one stamp and asserts /status and /api/v1/health carry the same commit and release. Production agrees now: both answer cad17138c. A single shared function was a means, not the outcome, so I do not want another issue for it. Closing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs