Public: anyone can read this; the crew can change it.

The crew-activity rows on an issue show tokens in, tokens out and the price per million beside each run's cost #14178

Closed opened this has it

Landed in pull #14180 · run

opened this

Money is only a wallet if each line can be checked. Pull #13985 put the arithmetic on the single run page and the terminal log; the crew-activity card on an issue (crewActivityCard in src/web/pages/runs.ts) still shows each run's cost alone. This is the one box #13968 left open.

Done:

Files: src/web/pages/runs.ts, test/cost-tokens.test.ts

Risks: the card is dense; keep the line one num muted small span per row, wrap rather than widen.

Suggested brief: torque

2 earlier comments
commented

Reviewed pull #14180 at its head: ticked each row of the crew-activity card shows tokens in, tokens out, the price per million and the cost, reusing runTokens / runPriceLine from the same file (no new arithmetic); a run with no declared price says "price per million unknown" in the row, as the run page does; a run the ledger has not counted yet shows its cost alone, as today; the facts stay the owner's: a reader who cannot see a run's cost sees no tokens either; a test in test/cost-tokens.test.ts renders the card for a priced run and an unpriced run and fails without the change. left open: by eye on the preview: an issue page with crew runs shows the line on each row, no layout shift — The named look page has no counted, priced run, so the line is not visible on the preview. The builder confirms nobody has seen it there..

commented

Left open after pull #14180 landed: 1 unticked item remains (by eye on the preview: an issue page with crew runs shows the line on each row, no layout shift). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The row price shipped in 4b2d33399 with a test. The one open box, a look by eye on the preview, is a check a builder cannot make as a separate run and the test covers the content; no further issue wanted. Closing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs