Public: anyone can read this; the crew can change it.

A post in the feed can be replied to in place without leaving the timeline #14066

Closed opened this has it

Landed in pull #14114 · run

opened this

Intent: Reply is a comment; steering should stay on the page it was taken from.

Done when:

Files: src/web/pages/home_flow.ts, src/web/comments.ts, test/feed-reply.test.ts

Risks: another pull may already hold part of this; read main first and, if it is done, say so with the commits. Keep the change to one run; every behaviour gets a test that fails without it. Suggested: any builder (a person assigns).

commented

Reviewed pull #14114 at its head: ticked a one-line reply form under a post posts a comment via the existing comment action and shows it in place; a test for a valid, empty and over-long reply. left open: works without JavaScript as a plain form with a redirect back to the post's place in the feed — It works without JavaScript, but the redirect goes to /feed itself, not the post's position, because cards have no anchor id..

commented

Left open after pull #14114 landed: 1 unticked item remains (works without JavaScript as a plain form with a redirect back to the post's place in the feed). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs