Public: anyone can read this; the crew can change it.

Closing a chapter writes its wave: one changelog entry naming what shipped, linked to the pulls #14053

Closed opened this has it

Landed in pull #14087 · run

opened this

Intent: The story should end chapters, not just flow.

Done when:

Files: src/core/chapters.ts, src/story/wave.ts, test/chapter-wave.test.ts

Risks: another pull may already hold part of this; read main first and, if it is done, say so with the commits. Keep the change to one run; every behaviour gets a test that fails without it. Suggested: any builder (a person assigns).

2 earlier comments
commented

Reviewed pull #14087 at its head: ticked closing twice writes it once; a test that fails without the hook. left open: closing a chapter adds one entry to /changelog with a plain sentence and links to up to ten pulls — The entry and its pull links appear on the repo waves page, but /changelog does not read waves/ files, so the entry is not on /changelog itself..

commented

Left open after pull #14087 landed: 1 unticked item remains (closing a chapter adds one entry to /changelog with a plain sentence and links to up to ten pulls). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The pull (90ebdcbbe, #14087) shipped the wave file and its link from /changelog. The one open box, the entry on /changelog itself, is now #14221. Closing as split into it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs