Public: anyone can read this; the crew can change it.

A surviving cell keeps its heartbeat: move the beat door out of the host process (follow-up to #13755) #13880

Closed opened this

Picked up by torque; no pull came of it (failed) · 5 runs

opened this

#13755 moves the egress proxy, loopback relays and inbound relay into a supervisor. openBeatDoor (src/spawn/beat-door.ts) still runs in the host, so a cell that outlives the host loses its heartbeat. Move it (or re-open it on adoption) before FORGE_CELLS_OUTLIVE is documented. Also needed first: re-adopt or reap supervised cells on boot (#13750 step 2).

6 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: this issue can't be done yet because the supervisor it builds on isn't on main. #13880 asks to move openBeatDoor out of the host process into the supervisor that #13755 introduces. #13755 is still

commented

Parked by the crew: the run ended without a pull: declined: the supervisor this issue builds on is not on main, so there is nothing to move openBeatDoor into.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this issue can't be done yet because the supervisor it builds on isn't on main. #13880 asks to move openBeatDoor out of the host process into the supervisor that #13755 introduces. #13755 is still
  2. the run ended without a pull: declined: the supervisor this issue builds on is not on main, so there is nothing to move openBeatDoor into

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

The supervisor from #13755 still isn't on main. Searching src for "supervisor" finds nothing relevant, and neither the git log nor the code mentions it. FORGE_CELLS_OUTLIVE appears nowhere either. Previous runs were parked for the same reason.

DECLINED: the supervisor from #13755 (egress proxy, loopback relays and inbound relay) is not on main. There is no supervisor process to move openBeatDoor into, and no FORGE_CELLS_OUTLIVE mechanism or boot-time adoption of cells (#13750 step 2) to re-open it on. This issue should wait behind #13755 and #13750, or be replaced by one that includes the supervisor itself.

commented

Parked by the crew: the run ended without a pull: no changes pushed: The supervisor from #13755 still isn't on main. Searching src for "supervisor" finds nothing relevant, and neither the git log nor the code mentions it. FORGE_CELLS_OUTLIVE appears nowhere eithe

Parked 3 times since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this issue can't be done yet because the supervisor it builds on isn't on main. #13880 asks to move openBeatDoor out of the host process into the supervisor that #13755 introduces. #13755 is still
  2. the run ended without a pull: declined: the supervisor this issue builds on is not on main, so there is nothing to move openBeatDoor into
  3. the run ended without a pull: no changes pushed: The supervisor from #13755 still isn't on main. Searching src for "supervisor" finds nothing relevant, and neither the git log nor the code mentions it. FORGE_CELLS_OUTLIVE appears nowhere eithe

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Parked by the crew: the run ended without a pull: declined: nothing has changed since the earlier parks. origin/main is the same commit as my base, and #13755's supervisor still isn't on it. The only "supervisor" hits in src are unrelated: apps/busy.ts,

Parked 4 times since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this issue can't be done yet because the supervisor it builds on isn't on main. #13880 asks to move openBeatDoor out of the host process into the supervisor that #13755 introduces. #13755 is still
  2. the run ended without a pull: declined: the supervisor this issue builds on is not on main, so there is nothing to move openBeatDoor into
  3. the run ended without a pull: no changes pushed: The supervisor from #13755 still isn't on main. Searching src for "supervisor" finds nothing relevant, and neither the git log nor the code mentions it. FORGE_CELLS_OUTLIVE appears nowhere eithe
  4. the run ended without a pull: declined: nothing has changed since the earlier parks. origin/main is the same commit as my base, and #13755's supervisor still isn't on it. The only "supervisor" hits in src are unrelated: apps/busy.ts,

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Parked by the crew: the run ended without a pull: declined: nothing has changed since the last park, and the supervisor this issue builds on is still not on main.

Parked 5 times since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this issue can't be done yet because the supervisor it builds on isn't on main. #13880 asks to move openBeatDoor out of the host process into the supervisor that #13755 introduces. #13755 is still
  2. the run ended without a pull: declined: the supervisor this issue builds on is not on main, so there is nothing to move openBeatDoor into
  3. the run ended without a pull: no changes pushed: The supervisor from #13755 still isn't on main. Searching src for "supervisor" finds nothing relevant, and neither the git log nor the code mentions it. FORGE_CELLS_OUTLIVE appears nowhere eithe
  4. the run ended without a pull: declined: nothing has changed since the earlier parks. origin/main is the same commit as my base, and #13755's supervisor still isn't on it. The only "supervisor" hits in src are unrelated: apps/busy.ts,
  5. the run ended without a pull: declined: nothing has changed since the last park, and the supervisor this issue builds on is still not on main

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #13906. Two runs declined this because the supervisor from #13755 is not on main yet. #13906 says the same thing and also waits on #13755, so no builder picks it up before that supervisor exists.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs