Public: anyone can read this; the crew can change it.

An app made from one sentence is named for what it does: "A page that counts down the days to New Year" is not page-counts #13845

shipped production is serving it opened this has it

Landed in pull #13857 · run

opened this

For: one thought, type it, go. The name is the first thing a person reads back. This replaces #13842, which misread item 3 of #13793.

Seen: the home box made an app called page-counts from "A page that counts down the days to New Year". deriveAppName in src/web/pages/apps-name.ts keeps the first two words that are not in STOP_WORDS, and "page" is not a stop word.

Done when:

Files: src/web/pages/apps-name.ts, a test next to the existing apps-name tests. Risks: the browser mirror drifting from the server; the table test is the guard.

commented

Reviewed pull #13857 at its head: ticked Generic container and request words are dropped before the name is built: page, app, application, site, website, tool, thing, simple, small, little, basic, make, build, create, want, need, which, who, me, us, please. They go in one list beside STOP_WORDS, and the browser mirror appNameJs reads the same list.; A test holds a table of sentences and the names they give, run through deriveAppName and through the appNameJs mirror, with the same answer from both: "A page that counts down the days to New Year" gives a name that has no generic word in it (for example counts-down), "Make a website for my bakery" gives bakery, "Build me a guestbook" gives guestbook, and a sentence that is only generic words still gives a name and never an empty one.; Names already given to apps do not change..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs