Public: anyone can read this; the crew can change it.

Drop feature_schedule_seen, and its entry in scripts/unread-tables-allow.json #13764

open deferred: behind the Later gate opened this

Picked up by mason; no pull came of it (failed) · 4 runs

Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

#13533 folded a feature's schedule into schedules; nothing reads feature_schedule_seen any more and clearFires (src/core/feature_fires.ts) only deletes from it. A drop is not additive across a roll (the old release still reads it), so it waits one release: once the release that stops reading it is live, add a migration that drops the table, remove it from clearFires, and remove it from scripts/unread-tables-allow.json.

7 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: the premise doesn't hold on this branch. #13533 isn't the schedule fold-in here. The only commit that mentions 13533 is a crew-cost change (13533e2f7), and no migration creates a schedules table.

commented

The table is still read here, so the premise fails. The fold into schedules isn't on this branch.

DECLINED: the table is still in use on this branch, so there's nothing to drop yet.

  • scheduleSince and scheduleSeen in src/core/feature_fires.ts (lines 86, 88 and 94) still read and write feature_schedule_seen. They aren't dead code, and clearFires is only one of its users.
  • No migration or code creates a schedules table. The only match for schedules is in src/actions/schedules.ts, plus uses elsewhere. A search for CREATE TABLE ... schedules found nothing.
  • The only feature_schedule_seen table definition is src/core/migrations/20261114020000-feature-run.ts.
  • This is the same premise failure the earlier parked attempt found. The issue depends on the fold-in landing first (#13533 as the issue describes it), and then on a release that stops reading the table.

I made no changes and pushed nothing.

commented

Parked by the crew: the run ended without a pull: no changes pushed: The table is still read here, so the premise fails. The fold into schedules isn't on this branch.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the premise doesn't hold on this branch. #13533 isn't the schedule fold-in here. The only commit that mentions 13533 is a crew-cost change (13533e2f7), and no migration creates a schedules table
  2. the run ended without a pull: no changes pushed: The table is still read here, so the premise fails. The fold into schedules isn't on this branch

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

The table is still read and written here, and the fold-in into schedules isn't on this branch. That's the same premise failure the two earlier attempts hit.

DECLINED: feature_schedule_seen is still in use on this branch, so there is nothing to drop yet. I made no changes and pushed nothing.

  • scheduleSince and scheduleSeen in src/core/feature_fires.ts (lines 85–94) read and write the table.
  • src/apps/feature_schedule.ts:118 calls scheduleSince, and src/actions/features.ts:252 calls scheduleSeen.
  • src/core/migrations/20261114020000-feature-run.ts is the only place the table is created.
  • The schedules fold-in from #13533 hasn't landed here, and no release has stopped reading the table.

This issue should wait for the fold-in to land, then for the release that stops reading the table. The planner can then re-scope it as the drop migration plus the clearFires and allowlist cleanup.

commented

Parked by the crew: the run ended without a pull: no changes pushed: The table is still read and written here, and the fold-in into schedules isn't on this branch. That's the same premise failure the two earlier attempts hit.

Parked 3 times since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the premise doesn't hold on this branch. #13533 isn't the schedule fold-in here. The only commit that mentions 13533 is a crew-cost change (13533e2f7), and no migration creates a schedules table
  2. the run ended without a pull: no changes pushed: The table is still read here, so the premise fails. The fold into schedules isn't on this branch
  3. the run ended without a pull: no changes pushed: The table is still read and written here, and the fold-in into schedules isn't on this branch. That's the same premise failure the two earlier attempts hit

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Parked by the crew: the run ended without a pull: declined: the premise is unchanged, so I made no changes and pushed nothing. This is the fourth attempt to hit the same wall.

Parked 4 times since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the premise doesn't hold on this branch. #13533 isn't the schedule fold-in here. The only commit that mentions 13533 is a crew-cost change (13533e2f7), and no migration creates a schedules table
  2. the run ended without a pull: no changes pushed: The table is still read here, so the premise fails. The fold into schedules isn't on this branch
  3. the run ended without a pull: no changes pushed: The table is still read and written here, and the fold-in into schedules isn't on this branch. That's the same premise failure the two earlier attempts hit
  4. the run ended without a pull: declined: the premise is unchanged, so I made no changes and pushed nothing. This is the fourth attempt to hit the same wall

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Parked by the crew: runs on this issue repeated more than three times in ten minutes, so nothing more starts here until a person says what to try.

commented

Deferred by Atlas, 2026-11-16. Four runs ended without a pull for one reason: the premise is not true on main yet. #13533's fold of feature.schedule into schedules has not landed (it waits on an open pull), and on origin/main (9feb8355b) src/core/feature_fires.ts still reads and writes feature_schedule_seen (lines 86, 88, 94, 99). So no builder can drop the table, and the issue says itself that a drop has to wait one release after the last reader goes. Dropping an unread table is also cleanup, and the owner's rule until v1.0.0 keeps that kind of work out of line. I am putting it behind the Later gate (#595). Pick it up once #13533 has landed and the release that stops reading the table is live.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs