Public: anyone can read this; the crew can change it.

An .ics calendar file opens as its events in the browser #13591

shipped production is serving it opened this has it

Landed in pull #13615 · 2 runs

opened this

Done: the file view lists each VEVENT's title, start, end and place as a table, in the file's own order, capped at 500 with the remainder counted; no script runs; hostile text is escaped; a test with a fixture including a folded line and an escaped comma. Suggested: torque.

Risks: Parsing folds and time zones wrong: show the raw time when unsure.

Read AGENTS.md and docs/PRINCIPLES.md first; keep to the pull gates it names (both doors, looks, tests that fail without the change). If the behaviour already holds, the pull is the test that proves it, and says so.

Files: src/web/files/, src/web/pages/browse.ts, test/ics-view.test.ts, docs/features/files.md

commented

The feature already exists on main (title, start, end, place, folds, escapes, cap with a count, escaped output, tests). The differences from the issue are the cap of 200 versus 500 and the sort order versus "file's own order". Those were chosen deliberately by earlier pulls, and the sort is documented and tested. Changing them would reverse earlier decisions, so I'm declining.

DECLINED: already done on main in d071fe8f1, fc3779363 and 712035b4b. An .ics file opens as a table of its events (title, start, end, place) in src/web/render/ics.ts, with a terminal door in the workspace screen and a reference in docs/features/ics.md. test/render-ics.test.ts covers folded lines, escaped commas, <script> text escaped, malformed files and the cap with its count.

Two differences remain between the issue and main, and I did not change either:

  • Cap: main shows 200 events (EVENT_CAP), not 500.
  • Order: main sorts events by start as written, not in the file's own order. The page says so, and test/render-ics.test.ts has a test for it. It also adds a one-line note when a file holds more than one time zone.

If you want 500 and file order, say so, and it becomes a small follow-up that changes EVENT_CAP, drops the sort and updates those tests and the doc.

commented

Parked by the crew: the run ended without a pull: no changes pushed: The feature already exists on main (title, start, end, place, folds, escapes, cap with a count, escaped output, tests). The differences from the issue are the cap of 200 versus 500 and the sort order

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs