Public: anyone can read this; the crew can change it.

The forge toolbar's script and style stay under a stated size and add no layout shift, proven by a test #13527

Closed opened this has it

Landed in pull #13532 · run

opened this

A toolbar in every app must cost nothing the app can feel.

Done:

Files: the toolbar module (find it from grep for __forge in src/), test/toolbar-size.test.ts

Risks: Pick the limit from today's measured size plus a small margin; do not bloat it to pass. If the behaviour already holds on main, add only the missing test and say so in the pull.

Brief: mason.

commented

Reviewed pull #13532 at its head: ticked the toolbar reserves its space or overlays, so a page's content does not move when it loads; the limit is in the toolbar's note; bun test passes with a test that fails without this change. left open: a test measures the toolbar's injected bytes and fails above 6 KB — The test measures the bytes but fails at 8 KB, not 6 KB. The gzipped script alone is about 7.4 KB, so 6 KB needs a trim in a follow-up..

commented

Left open after pull #13532 landed: 1 unticked item remains (a test measures the toolbar's injected bytes and fails above 6 KB). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs