Public: anyone can read this; the crew can change it.

A forge link says when it expires on opening, and an expired link offers one way to ask for a fresh one #13525

Closed opened this has it

Landed in pull #13564 · run

opened this

A client who opens a dead link must not meet a bare error.

Done:

Files: src/actions/codes.ts, src/actions/invites.ts, test/forge-link-expiry.test.ts

Risks: The expired page must not reveal whether a forge exists; same words for a made-up code. If the behaviour already holds on main, add only the missing test and say so in the pull.

Brief: torque (forge in a link).

commented

Reviewed pull #13564 at its head: ticked opening a live link shows its expiry in plain words; no detail of the forge is shown on an expired link; bun test passes with a test that fails without this change. left open: an expired link answers one sentence and a 'ask for a new link' action that notifies the sender — The action only records an event on the claimed forge's own feed. It does not reach the sender on the parent forge..

commented

Left open after pull #13564 landed: 1 unticked item remains (an expired link answers one sentence and a 'ask for a new link' action that notifies the sender). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs