Public: anyone can read this; the crew can change it.

A tell sent from an app's forge toolbar carries the app, the page it was sent from and the pull number when in a preview #13487

Closed opened this has it

Landed in pull #13497 · run

opened this

Intent: steering from inside an app reaches the crew with its context.

Done:

Risks: the preview page may hold private data; send only the path, never page text. Suggested: scout. Files: src/apps/toolbar.ts, test/apps-toolbar-context.test.ts

commented

Reviewed pull #13497 at its head: ticked the toolbar's tell posts the app slug, the page path and, in a preview, the pull number; the path is validated and escaped; test with a hostile path. left open: the resulting issue or ask shows that context as one line the crew reads — In a preview it is one line; in production the page and the app are two separate lines..

commented

Left open after pull #13497 landed: 1 unticked item remains (the resulting issue or ask shows that context as one line the crew reads). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs