Public: anyone can read this; the crew can change it.

A CSV, TSV or JSON-lines file over 5 MB opens its first 1,000 rows and says how many it did not show #13465

Closed opened this has it

Landed in pull #13494 · run

opened this

Intent: Big files open fast and say what they cut.

Done when:

Files I expect to change: the CSV/data file renderer under src/web/ or src/data/, test/

Risks: a final partial line in the prefix: drop it.

Suggested brief: torque. One pull; leave the busiest shared files alone. Reachable means on the page, in a test and by eye.

commented

Reviewed pull #13494 at its head: ticked the viewer reads a bounded prefix of the bytes, never the whole file; the page says 'Showing 1,000 of about N rows' or 'of more than 1,000'; bun test passes with a test that fails without this change. left open: memory stays bounded; a test feeds a generated 20 MB file under a time budget — The 20 MB file is generated and the source and page are asserted bounded (prefix <= 2 MB, page < 2 MB), but the time budget was removed to avoid flakes, so that part of the box is not tested..

commented

Left open after pull #13494 landed: 1 unticked item remains (memory stays bounded; a test feeds a generated 20 MB file under a time budget). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs