Public: anyone can read this; the crew can change it.

The forge toolbar is never added to non-HTML responses or twice to one page, proven by a test #13446

shipped production is serving it opened this has it

Landed in pull #13455 · run

opened this

Intent: The toolbar in every app and preview must not break an app's JSON, images, or downloads.

Done when:

Files I expect to change: the toolbar injection module (grep the toolbar's script tag), test/

Risks: a streamed or compressed body; test with both.

Suggested brief: mason. Keep to one pull; leave the busiest shared files alone. Reachable means on the page, in a test and by eye.

commented

Reviewed pull #13455 at its head: ticked an app's JSON, text, image and download responses pass through byte for byte; an HTML page already carrying the toolbar gets exactly one; a page with no </body> is left unchanged or gets the toolbar once, by a stated rule; bun test passes with a test that fails without this change.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs