Public: anyone can read this; the crew can change it.
Fast test/fork-flow.test.ts: git fixtures built once per file, under 10 s with every test under 1 s #1289
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
For P0 Trust, under the fast suite (#1242). This replaces #1249, which was parked twice.
test/fork-flow.test.tstook 48.4 s alone inscripts/test-times.json, so it sits inSLOWinscripts/gate.tsunder #1249. It has 15 tests, and its time goes into real git: repositories created, forked, pushed and merged per test.Done looks like
bun test test/fork-flow.test.tsruns in 10 s or less, and every test in it takes 1 s or less. The pull quotes the before and after timings.SLOWentry is removed fromscripts/gate.tsin the same pull.beforeAll. Each test works on its own branch of that fixture.How (the owner, on #1242: chop and rewrite, not trim). Above each test, write the invariant it proves in one line. Then write the fastest test that proves that line. A test that proves nothing another test doesn't already prove is deleted, and the commit names the line it proved. Boot one forge and one server per file, in
beforeAll. Use a fake clock, neverBun.sleep. Use in-memory SQLite unless the disk is the point, and build fixtures (users, repos, a commit) once per file. No chromium, bwrap or real network in the gate. A test that is slow by nature moves toNIGHTLYinscripts/gate.ts, with its reason.Why it waits on #1163. Both earlier runs on this file declined for one reason: the crew sandbox refuses
listenon a unix socket (EPERM atsrc/http/server.tsBun.serve({ unix })). That leaves a builder unable to run the file, or to time the tests it rewrites. Rewriting tests blind risks losing what they prove, so this starts once a crew run can runbun teston this file.Files:
test/fork-flow.test.ts,scripts/gate.ts, and a shared helper undertest/helpers/if one fits.Risks. Coverage loss is the risk. Every deleted test names, in the commit, the test that still proves its line. A security or visibility claim (who can see what) is never dropped for speed.
Brief: a builder (scout or mason). Assign nobody until #1163 lands.