Public: anyone can read this; the crew can change it.

An .xlsx file opens as a table: its sheet names and the first 200 rows of the first sheet #12688

shipped production is serving it opened this has it

Landed in pull #12714 · run

opened this

Intent: the owner stores anything; a spreadsheet should be read in the browser like a CSV.

Done:

Files: src/web/render/xlsx.ts (new), src/web/render/kinds.ts, src/web/render/renderers.ts, test/render-xlsx.test.ts (new). Risks: no dependency; reuse the zip reader. Suggested: torque.

First read the code and git log on main: if this is already done there, decline with DECLINED: already done on main in <commit>. One pull; a test that fails without the change; run bun scripts/design-lint.ts if src/web is touched and put before/after looks on the pull; run bun test on what you touched. Do not name or edit scripts/gate.ts in this change beyond what a new test file needs.

commented

Reviewed pull #12714 at its head: ticked kinds.ts maps .xlsx (first bytes PK\x03\x04 and a xl/workbook.xml entry) to kind "sheet"; else octet-stream.; A pure module reads the workbook through the existing zip reader in src/web/render/archive.ts: sheet names, shared strings (cap 20,000), first sheet cells to 200 rows x 30 columns, drawn like csv.ts draws its table; formulas show their cached value, never evaluated.; Zip bombs: cap inflated bytes per entry; hostile or missing parts fall back to the source view.; Every cell escaped; cells starting = + - @ are shown as text.; Test: a small generated xlsx, a truncated one, a bomb-sized claim..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs