Public: anyone can read this; the crew can change it.
The test runner has a looks lane: chromium test files run only where chromium starts, named *.looks.test.ts, out of the gate budget #12496
Landed in pull #12506
commented
Reviewed pull #12506 at its head: ticked scripts/test-shards.ts runs test/*.looks.test.ts in a looks lane only where findChromium() starts (the check box), and the gate tiers leave those files out; a test of the runner proves both.; test/oauth-connect-browser.test.ts becomes test/oauth-connect-browser.looks.test.ts, and its SLOW row in scripts/gate.ts is renamed to match (or moved to the lane's own budget), no assertion dropped.; test/loading-chrome.test.ts the same, if it fits the lane..
Sign in to join this conversation.
new above
offline
One sentence:
scripts/test-shards.tshas no lane for tests that drive a real Chromium, so they run in the gate and sit inSLOWinscripts/gate.ts; give them a lane of their own and move them into it.Done looks like:
Files: scripts/test-shards.ts, scripts/gate.ts, test/test-budget-run.test.ts, test/oauth-connect-browser.test.ts, test/loading-chrome.test.ts. Risks: scripts/gate.ts is a conflict file; keep the edit to the moved rows. Split off #12485's third box (review on #12490): the lane did not exist.