Public: anyone can read this; the crew can change it.
Act on a kept-result audit that disagrees: drop the kept entry and say so #12360
Picked up by torque; no pull came of it (failed) · 3 runs
4 earlier comments
The audit this issue acts on exists only in open pull #12352, which isn't on main, so I'm stopping without a change.
DECLINED: the audit lines (audit agrees / audit DISAGREES) and the audited set in splitKept exist only in open pull #12352. They are not on main, which this branch is based on (47e69913b). If I build on that unmerged code here, this pull would either duplicate #12352 or conflict with it.
There is also a design choice for the maintainers. Only the default branch's own measuring run may write the kept store (keepKept in src/checks/kept-store.ts, by design: "a pull's code never fills what another check reads"). A pull's run that sees a disagreement therefore can't drop the entry on its own. Two ways to handle it:
- The run writes the dropped keys to a separate file in the checkout, and the forge removes only those keys from the store, after validating them with
parseKept. - Dropping waits for the next default-branch run, which would re-audit and not re-keep the entry.
Once #12352 merges, re-queue this with a choice between those two, and between failing the run and only flagging it. I can then build it: an audited-to-dropped-keys step in kept.ts, the store removal, the log line and tests.
Parked by the crew: the run ended without a pull: no changes pushed: The audit this issue acts on exists only in open pull #12352, which isn't on main, so I'm stopping without a change.
Parked by the crew: the run ended without a pull: declined: the audit this issue acts on isn't on main. The audit agrees / audit DISAGREES lines and the audited set in splitKept exist only in open pull #12352. A search of this branch finds no `audit
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: no changes pushed: The audit this issue acts on exists only in open pull #12352, which isn't on main, so I'm stopping without a change
- the run ended without a pull: declined: the audit this issue acts on isn't on
main. Theaudit agrees/audit DISAGREESlines and theauditedset insplitKeptexist only in open pull #12352. A search of this branch finds no `audit
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Parked by the crew: the run ended without a pull: declined: the audit this issue acts on is not on main, so there is nothing to act on yet. The audit agrees / audit DISAGREES lines and the audited set in splitKept exist only in pull #12352, which is
Parked 3 times since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: no changes pushed: The audit this issue acts on exists only in open pull #12352, which isn't on main, so I'm stopping without a change
- the run ended without a pull: declined: the audit this issue acts on isn't on
main. Theaudit agrees/audit DISAGREESlines and theauditedset insplitKeptexist only in open pull #12352. A search of this branch finds no `audit - the run ended without a pull: declined: the audit this issue acts on is not on
main, so there is nothing to act on yet. Theaudit agrees/audit DISAGREESlines and theauditedset insplitKeptexist only in pull #12352, which is
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Deferred by the planner. Parked twice for one reason: the audit lines this acts on exist only in open pull #12352 (for #12178), not on main, so no builder can act on them yet. It now waits for #12178, and it sits behind the Later gate (#595) because it is not on the v1.0.0 list and is not a defect on that path. Once #12178 lands and v1.0.0 is tagged, it is one run as written.
#12178 (pull #12352) prints, for each sampled kept file,
audit agreesoraudit DISAGREESin the check log. Nothing acts on a DISAGREES yet. Follow-up: when an audit disagrees, delete that file's kept entry (or every entry sharing its inputs) so the key is not trusted again, and fail or flag the run as the maintainers choose.