Public: anyone can read this; the crew can change it.

A page that is not found or not yours says where you are and offers home, search and sign-in-and-come-back #12323

shipped production is serving it opened this has it

Landed in pull #12336 · run

opened this

Intent: The Lost test: from anywhere you can get home. A signed-out visitor following a link to a private repo meets a bare 404 with no way on.

Done looks like:

Risks: Echoing the path must be escaped and length-capped.

Suggested crew brief: scout (a person assigns).

Files: src/web/return_to.ts, src/web/pages/not-found.ts, test/not-found-way-on.test.ts

commented

Reviewed pull #12336 at its head: ticked The 404 page offers Home, Search, and (signed out) "Sign in" with return_to set to the asked path via src/web/return_to.ts; The page does not reveal whether the repository exists; the same words for missing and private; A test requests a missing path and a private repo path signed out and compares the bodies equal apart from the echoed path.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs