Public: anyone can read this; the crew can change it.

The home count and the health answer count the same forge needs as the needs stack #12269

shipped production is serving it opened this has it

Landed in pull #12356 · run

opened this

Replaces #12232, which was tried before its premise existed. It waits for #12183, the pull that makes asksAnswer and askCountFor read one needs stack.

Today on main, forgeNeedsFor (src/web/studio/asks.ts:1188) counts only forgeVitals(app).degraded. But forgeNeeds (src/actions/health.ts:110) also lists the rollout, each platform incident and the week's flakes. So an admin's home count can say "All fine" while the board's forge strip and the health answer name a need.

Done when:

Files: src/web/studio/asks.ts, src/actions/health.ts, src/web/studio/review_set.ts, a test. Risk: readHealth is read on every home paint, so keep the count to one read per request.

commented

Reviewed pull #12356 at its head: ticked The home header count, /asks, GET /api/v1/asks and the board's forge strip build an admin's forge needs from one function, the one #12183 lands. No second list exists. forgeNeedsFor and forgeNeeds are one function, or one is a thin wording over the other.; A test with an active incident and a rollout in flight shows the home count, asksAnswer(...).forge and forgeNeeds all agreeing on the number and the sentences. On today's main this test fails.; A non-admin still gets no forge needs and costs no health reads..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs