Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a is past its budget: trevato/forge: "cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray on… #12173

Closed opened this

Picked up by scout; no pull came of it (ok) · run

opened this

shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a is past its budget: trevato/forge: "cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray on…

Evidence

  • cause: shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a
  • sentence: trevato/forge: "cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray one is named by file and line" failed on 3 pulls in the last hour — the lane's red, not theirs; they wait for main's next green check, unparked.
  • since: 2026-11-13T19:56:10.876Z
  • href: /trevato/forge/issues/new
  • test: cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray one is named by file and line
  • failed: pull #12150, check run 01m7b6dgj7e2zcz019n0jmtfb8
  • failed: pull #12157, check run 01m7b6dgj5janwebmhg8v3fhw8
  • failed: pull #12147, check run 01m7b39yrx5xd2xdqrp21en50s
  • base: [redacted] (run 01m7b6dgj7e2zcz019n0jmtfb8)
  • log: 379 | for (const [file, { sites }] of Object.entries(UNREACHED)) expected[file] = sites;
  • log: 380 | const off = [...new Set([...Object.keys(found), ...Object.keys(expected)])]
  • log: 381 | .sort()
  • log: 382 | .filter((file) => (found[file]?.length ?? 0) !== (expected[file] ?? 0))
  • log: 383 | .map((file) => ${file}: ${found[file]?.length ?? 0} sites, the test names ${expected[file] ?? 0} (${(found[file] ?? []).join(", ") || "none left"}));
  • log: 384 | expect(off).toEqual([]);
  • log: ^
  • log: error: expect(received).toEqual(expected)
  • log: - []
  • log: + [
  • log: + "src/spawn/origin_broker.ts: 2 sites, the test names 0 (src/spawn/origin_broker.ts:327, src/spawn/origin_broker.ts:397)",
  • log: + "src/web/pages/home_flow.ts: 1 sites, the test names 0 (src/web/pages/home_flow.ts:499)",
  • log: + ]
  • log: - Expected - 1
  • log: + Received + 4
  • log: at <anonymous> (test/cookie-flags.test.ts:384:17)
  • main: passes on main's newest check, run 01m7b695ydm6mfjbb5d3py6grc at [redacted]

Pillar: P0 Trust: the forge says when it is not well, and is well again

What to look for when fixed: shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a is gone from the degraded list and the cause is fixed, not waited out.

Mechanical fix: Make the named test's verdict depend only on the code under test, not on the check machine's load, disk or clock, in one pull. Pulls red on it alone wait, unparked, for main's next green check.

Found by the sentinel at 2026-11-13T19:57:09.041Z.

4 earlier comments
commented

Live triage (automatic, not written by a person): filed under P0 Trust, which it names.

commented

Still there at 2026-11-13T20:58:36.871Z, evidence now:

  • cause: shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a
  • sentence: trevato/forge: "cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray one is named by file and line" failed on 7 pulls in the last hour — the lane's red, not theirs; they wait for main's next green check, unparked.
  • since: 2026-11-13T20:58:09.980Z
  • href: /trevato/forge/issues/12173
  • test: cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray one is named by file and line
  • failed: pull #12150, check run 01m7b9aspgg42djgr1qf6b990t
  • failed: pull #12177, check run 01m7b96jebv4h62t70bjey6bf2
  • failed: pull #12160, check run 01m7b8ba5ds09scdqgpxp4c343
  • failed: pull #12152, check run 01m7b8b43e6qgarmyyvhr8kfj2
  • failed: pull #12177, check run 01m7b88pfnhr8rcaqrs0fsmbrt
  • base: [redacted] (run 01m7b9aspgg42djgr1qf6b990t)
  • log: 379 | for (const [file, { sites }] of Object.entries(UNREACHED)) expected[file] = sites;
  • log: 380 | const off = [...new Set([...Object.keys(found), ...Object.keys(expected)])]
  • log: 381 | .sort()
  • log: 382 | .filter((file) => (found[file]?.length ?? 0) !== (expected[file] ?? 0))
  • log: 383 | .map((file) => ${file}: ${found[file]?.length ?? 0} sites, the test names ${expected[file] ?? 0} (${(found[file] ?? []).join(", ") || "none left"}));
  • log: 384 | expect(off).toEqual([]);
  • log: ^
  • log: error: expect(received).toEqual(expected)
  • log: - []
  • log: + [
  • log: + "src/spawn/origin_broker.ts: 2 sites, the test names 0 (src/spawn/origin_broker.ts:327, src/spawn/origin_broker.ts:397)",
  • log: + "src/web/pages/home_flow.ts: 1 sites, the test names 0 (src/web/pages/home_flow.ts:499)",
  • log: + ]
  • log: - Expected - 1
  • log: + Received + 4
  • log: at <anonymous> (test/cookie-flags.test.ts:384:17)
  • main: passes on main's newest check, run 01m7bb5fp6ycmsdq2bv83qrzxn at [redacted]
commented

Still there at 2026-11-13T21:58:51.838Z, evidence now:

  • cause: shared:01m23vygyffx5hg2f5vm8r74sr:1k4n3wbi9a
  • sentence: trevato/forge: "cookie-setting sites > every file's cookie sites are walked above or named, counted exactly; a stray one is named by file and line" failed on 7 pulls in the last hour — the lane's red, not theirs; they wait for main's next green check, unparked.
  • first open: 2026-11-13T19:56:10.876Z
  • total: 14 minutes in the day
  • href: /trevato/forge/issues/12173
commented

Done on main already, waiting for you to close it: fcebc11c0a90636522b29fb6f577aad34d14797e

commented

Closed: already done on main in fcebc11. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs