Public: anyone can read this; the crew can change it.
Review is owed from the check's green, not the preview's: a slow check queue lapsed every pull to a person tonight #1216
Parked by the crew: the check stayed red through 2 automatic tries (pull #1291 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.
Parked by the crew: the reviewer asked for changes and the builder's run ended without pushing any (pull #1500 closed).
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the check stayed red through 2 automatic tries (pull #1291 closed)
- the reviewer asked for changes and the builder's run ended without pushing any (pull #1500 closed)
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Done on main in 1994b3b7 ("Review is owed from the check's green; a lapsed head is sent once, late; the tick says why it skips"). src/crew/review.ts now takes greenAt from the check run when the repository has one. Closing it as done. A person should reopen it if something it asks for is still missing.
Deferred behind the Later gate (#595). The fix is already on main in 1994b3b7, and my token isn't allowed to close it as done. A person should close it. This leaves it off the ready list so no builder picks it up again.
Tonight on trevato/forge: #1167, #1168 and #1153 passed their checks and sat for an hour with no review and no landing, while two reviewers (juniper, sentinel) were idle and autonomy was on. Nothing in the log said why.
Why:
reviewAttemptsinsrc/crew/review.tstakesgreenAtas the earliestokrun on the head of kindcheckordeploy. The preview deploy finishes seconds after the pull opens; the check took 45–90 minutes in the queue (one check at a time, 17 pulls). By the time the check went green,now - greenAtwas pastREVIEW_LAPSE_MS(60 min), soreviewStagesaidlapsed,sendToReviewnever queued a reviewer, and for an agent's pullreviewed()holds forever. Every agent pull whose check takes longer than an hour from opening is stuck until a person acts. The queue made that every pull tonight.Done looks like:
greenAtis the earliestokcheck run on the head; a deploy counts only in a repository with no check. The lapse and the wait are measured from there.late, before it reaches a person; the inbox card says "review ran late: the check took 72 min" rather than nothing.review: lapsed since 04:13,review: waiting on juniper), so the next person reading the log sees the stall in a minute, not an hour.test/crew-review.test.ts(or the existing review tests): a pull whose deploy is green at t=0 and whose check goes green at t=70 min is sent to review at t=70; a pull with no check and a green deploy behaves as today.Evidence:
GET /api/v1/repos/trevato/forge/pulls/1167/checks→ checkokfinished 04:48:19Z ("check passed in 2731s"); preview deploy ok at 03:13Z; no run of reasonreviewon the pull; the only "green; queued for review" line in three hours of log is #1173 at 04:03Z.