Public: anyone can read this; the crew can change it.
An approval is recorded against the head and the base it was given for, and says when either moved #12158
commented
Parked by the crew: the check stayed red through 2 automatic tries: the real home reads as text: heading and waiting count, no CSS, script or tag (pull #12164 closed; its branch scout/12158-an-approval-is-recorded-against-the-head at be1fb2785c2c keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.
try 1: src/actions/pulls.ts, src/core/migration-pins/20261114070000-review-base.pin, src/core/migrations/20261114070000-review-base.ts, src/core/pulls.ts, src/… try 2: src/core/pulls.ts, src/http/api.ts, src/http/mcp/tools/pulls.ts, test/approval-base.test.ts
Sign in to join this conversation.
new above
offline
Split from #1133. A review records the base tip it was given against (
base_oidon review, set where approvals are written);approvedAtonGET /api/v1/repos/:owner/:name/pulls/:numbergainsbaseand stops being current when the head or the base moves; the pull page reads "approved at <head7> against <base7>"; and the pull rows that show approvals say "moved since approval". Tests: an approval goes stale when the base moves, and the API carriesapprovedAt.base.