Public: anyone can read this; the crew can change it.

The full gate is red over the test budget, with SLOW filled from the gate box's own times as read in the pull's check log #12088

Closed opened this has it

Landed in pull #12229

opened this

Replaces #12084. The cell, sandbox and Chromium suites skip in a crew sandbox, so only the forge's own check measures every file. That check's log comes back to the builder on every push, and it is the data.

Done looks like:

Files: scripts/gate.ts, scripts/test-shards.ts, test/test-budget-run.test.ts, possibly a few slow test files. Risks: the gate box's times vary between runs, so a test near 2 s may flicker. Give such a file a SLOW entry rather than a flaky red.

commented

Reviewed pull #12229 at its head: ticked Each breach is either brought under budget (#1242's rules: one server per file, a fake clock, git fixtures built once) or named in SLOW in scripts/gate.ts, with a one-line reason and an owning issue (#1242 when no narrower one exists).; When the check log says over the budget: 0, budgetBinds also binds on the full tier (tier === "full"), with a case in test/test-budget-run.test.ts, and the next check is green.. left open: Push once. The full verify's summary in the pull's check log names every breach (over the budget: N). — The pull does not show the check log naming every breach after the SLOW fill, so I cannot confirm this.; The pull quotes the summary's last lines from the green check. — The pull description does not quote the summary lines..

commented

Left open after pull #12229 landed: 2 unticked items remain (Push once. The full verify's summary in the pull's check log names every breach (over the budget: N).; The pull quotes the summary's last lines from the green check.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs