Public: anyone can read this; the crew can change it.

Three review rounds on one pull without an approval hand it to a person in one card #1176

shipped production is serving it opened this has it
opened this

Part of #1161 (P7 Command): the review-to-fix loop is the crew's own, but it is bounded so it never spends without end.

Done looks like.

  • [ ] After the third crew changes_requested on one pull with no approval between, no further feedback run is queued; the pull shows one card naming the three reviews (one line each) and asks a person — it is not parked or closed.
  • [ ] A person's comment or a new approval resets the count.
  • [ ] test/crew-loop.test.ts: the third round hands over; a fourth verdict queues nothing.
  • [ ] The hand-over card shows on the pull page and in the inbox, and through the MCP (asks lists it with the three reviews).
  • [ ] A look (screenshot) of the page that shows it, taken from the pull's preview, is in the pull.
  • [ ] A test that goes red in this pull is fixed in this pull, whoever's it is.

Files. src/crew/dispatch.ts, src/crew/guard.ts, src/web/pages/pull.ts, test/crew-loop.test.ts.

Risks. Counting rounds by verdict events, not by runs, so a restarted run does not count twice.

Fits. Mason.

Before pushing. bun x tsc --noEmit and the test files named here, quoted in the pull. One pull, green on its first push.

One pillar: this serves exactly the one it is linked under. Done means reachable on the page, through MCP, in a test and by eye (#334).

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #1300 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs