Public: anyone can read this; the crew can change it.

branches, cli-sync, code, counts, crew-loop and crew-totals join the gate, proven by the pull's own check #1164

shipped production is serving it opened this has it
opened this

Pillar: P0 Trust (umbrella #586), part of #261. This replaces #917. Both its runs declined because the builder couldn't run these files in its sandbox: every server test fails with EPERM on the hook socket (#1163 fixes that). This issue doesn't wait for that. Its proof is the pull's own check, which runs on the forge, where the sockets work.

Intent. The gate runs branches, cli-sync, code, counts, crew-loop and crew-totals. Pull #890 found all six green. The forge's check on the pull is the proof.

Done looks like.

  • [ ] Start from today's main. In scripts/gate.ts, these six entries move from EXCLUDED (reason: "not yet admitted") to GATE: test/branches.test.ts, test/cli-sync.test.ts, test/code.test.ts, test/counts.test.ts, test/crew-loop.test.ts, test/crew-totals.test.ts. Nothing else changes.
  • [ ] Push. The forge's check on the pull is green. Don't decline because the tests can't run locally: a local EPERM … listen is the known sandbox limit, not a result.
  • [ ] If the check is red on one of these six files, that file goes back to EXCLUDED with reason: "red: <the failing case, one line>", issue: 261, and you push again. Its test isn't edited. If the check is red on a file outside these six, the pull says so and quotes the line. It is not this pull's to fix.
  • [ ] The pull quotes the check's wall time and each of the six files' times from the check log. The total stays under the check's timeout.
  • [ ] test/check-list.test.ts stays green.

Files. scripts/gate.ts only, and scripts/test-times.json if the check asks for it.

Risks. A flaky file that every pull then pays for. If any of the six is slow or flaky in the log, leave it out and say so. #1140 lists the same six in its range. Whoever takes #1140 picks from the files left over.

Suggested: scout or mason.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs