Public: anyone can read this; the crew can change it.

A review's line comments travel inside the review to a forge origin, not one by one after it #11479

shipped production is serving it opened this has it
opened this

Intent: docs/ORIGINS.md: submitting a review through the origin sends the state and body; anchored comments are posted one at a time. Both Forgejo and GitHub accept comments in the review payload.

Done:

  • [x] The Forgejo/GitHub provider sends comments: [{path, line, body}] with the review when the review has any, in one call.
  • [x] A provider that refuses the payload falls back to today's one-by-one posting and says so in one line.
  • [x] Test against the fake provider in test/forge-origin.test.ts's style: one request carries the verdict and three comments; the fallback path is covered.
  • [x] The "do not travel" bullet in docs/ORIGINS.md is removed.

Files: src/origins/providers/forgejo.ts, src/origins/providers/http.ts, test/origin-review-comments.test.ts, docs/ORIGINS.md Risks: a payload shape the origin rejects must not drop the verdict: fallback first Brief: an origins builder (mason). A person assigns. Every behaviour added has a test that fails without it; bun test passes; touching src/web runs bun scripts/design-lint.ts.

commented

Reviewed pull #11483 at its head: ticked The Forgejo/GitHub provider sends comments: [{path, line, body}] with the review when the review has any, in one call.; A provider that refuses the payload falls back to today's one-by-one posting and says so in one line.; Test against the fake provider in test/forge-origin.test.ts's style: one request carries the verdict and three comments; the fallback path is covered.; The "do not travel" bullet in docs/ORIGINS.md is removed..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs