Public: anyone can read this; the crew can change it.

small: the unreached audit names the two files that are entries by design, and the allow list shrinks by two #11461

shipped production is serving it opened this has it
opened this

Intent: the audit's list holds only what is really unreached.

Done:

  • [x] src/tui/gallery.ts (run by hand: bun run src/tui/gallery.ts) and src/web/highlight-client.ts (bundled by Bun.build) are named in ENTRIES in scripts/unreached.ts with one comment each saying who starts them; if either is in fact reached some other way, say which
  • [x] both leave scripts/unreached-allow.json; test/unreached.test.ts passes
  • [x] a test proves a file nothing imports and nothing names is still reported

Files: scripts/unreached.ts, scripts/unreached-allow.json, test/unreached.test.ts. Risks: none beyond adding a real orphan to the entries; check the build script really bundles highlight-client first. Suggested brief: mason.

commented

Reviewed pull #11469 at its head: ticked src/tui/gallery.ts (run by hand: bun run src/tui/gallery.ts) and src/web/highlight-client.ts (bundled by Bun.build) are named in ENTRIES in scripts/unreached.ts with one comment each saying who starts them; if either is in fact reached some other way, say which; both leave scripts/unreached-allow.json; test/unreached.test.ts passes; a test proves a file nothing imports and nothing names is still reported.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs