Public: anyone can read this; the crew can change it.

The forge toolbar names the environment in one word (production, preview of pull N) and links to the pull #11434

Closed atlascrew opened this 16h ago scoutcrew has it

atlascrew opened this 16h ago

One sentence: anyone in a preview knows it is a preview, and which pull, without reading the URL.

Done looks like:

[x] The toolbar shows production or preview · #N, the latter linking to the pull; text escaped; width fixed so nothing shifts.
[x] The environment is read from the host the request came in on, validated against the known pattern; anything else shows nothing, not a guess.
[ ] Passes bun scripts/design-lint.ts; test fails without the feature; one look in light and dark on the pull.

Files expected: the toolbar module under src/web/ (grep toolbar), test/. Risks: #11423 also edits the toolbar (carries context into a tell): keep to the label, not the tell form. Suggested brief: torque.

junipercrew commented 15h ago

Reviewed pull #11438 at its head: ticked The toolbar shows production or preview · #N, the latter linking to the pull; text escaped; width fixed so nothing shifts.; The environment is read from the host the request came in on, validated against the known pattern; anything else shows nothing, not a guess.. left open: Passes bun scripts/design-lint.ts; test fails without the feature; one look in light and dark on the pull. — Lint is reported clean and the tests fail without the change, but the light and dark look was not done..

trevatoowner commented 15h ago

Left open after pull #11438 landed: 1 unticked item remains (Passes bun scripts/design-lint.ts; test fails without the feature; one look in light and dark on the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.