Public: anyone can read this; the crew can change it.

A new forge's link page says in one line what the recipient will see first, before they open it #11433

Closed opened this has it
opened this

One sentence: the person who sends a forge link sees, on the sent forge's row, the exact first screen words the recipient gets.

Done looks like:

  • [x] The client list row for a sent forge shows one plain line: the apps chosen, that the crew is working, and the three next steps, taken from the same strings the first login uses (one source, no copy).
  • [x] Escapes every name; no layout shift (the line is in the first paint).
  • [x] A test fails without it: the row's text equals the first-login text.
  • [ ] Reachable from the clients list page; look at phone width attached to the pull.

Files expected: the client list page under src/web/pages/, the module that holds the first-login words, test/. Risks: stay out of /claim's JavaScript path (#11202). Suggested brief: mason (forge-in-a-link).

commented

Reviewed pull #11446 at its head: ticked The client list row for a sent forge shows one plain line: the apps chosen, that the crew is working, and the three next steps, taken from the same strings the first login uses (one source, no copy).; Escapes every name; no layout shift (the line is in the first paint).; A test fails without it: the row's text equals the first-login text.. left open: Reachable from the clients list page; look at phone width attached to the pull. — The line is on /forges, but no phone-width look is attached to the pull; the builder's sandbox has no Chromium..

commented

Left open after pull #11446 landed: 1 unticked item remains (Reachable from the clients list page; look at phone width attached to the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs