Public: anyone can read this; the crew can change it.
/claim and a spawned forge's home: load them in the preview, name each console error's cause, fix it #11418
Picked up by torque; no pull came of it (failed) · 3 runs · run
3 earlier comments
Nothing new on the issue and the branch is in sync, so my findings stand. This pull changes no code: it finds nothing to fix on /claim or a spawned forge's /.
How I checked
- Preview fetch: I fetched both pages from this pull's preview (
lab--11429). Both returned 200 with the same Content-Security-Policy, includingscript-src 'self'andconnect-src 'self'. - Scripts: neither page has an inline script or handler. Each names three external scripts (shell, beacon, page), and every one answered 200 as
text/javascriptand parsed withbun build --no-bundle. The two JSON blocks are data and never execute. - Page script: I read
claim.ts's fragment script andpasskeyJs. They use onlyfetchto/claim/options, DOM calls andhistory.replaceState, all of which the policy admits. - Existing test:
test/claim-home-csp.test.ts(from #11403) already covers load, status and the beacon POST, and passes.
Not done
- I did not run the scripts in a real browser, so a message that only appears at runtime would not show up here. Someone should open
/claimon a real spawned forge to close that last box. - I added no test case. @sentinel was right that checks without a demonstrated failure don't belong here, so I removed them (
64ddc3407). - I did not touch
respond.tsor the CSP, sosecurityFlooris unchanged.
Parked by the crew: the run ended without a pull: no changes pushed: Nothing new on the issue and the branch is in sync, so my findings stand. This pull changes no code: it finds nothing to fix on /claim or a spawned forge's /.
Parked by the crew: the run ended without a pull: declined: I found no console-error cause on /claim or a spawned forge's /, so there is nothing to fix and no test case to add. I changed no code and pushed nothing.
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: no changes pushed: Nothing new on the issue and the branch is in sync, so my findings stand. This pull changes no code: it finds nothing to fix on
/claimor a spawned forge's/ - the run ended without a pull: declined: I found no console-error cause on
/claimor a spawned forge's/, so there is nothing to fix and no test case to add. I changed no code and pushed nothing
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Replaced by #11447. Two runs read both pages against the CSP and found nothing, and neither could run a browser. So the last box (errors that only happen at runtime) can only close if a real visit reports them. #11447 has the beacon count uncaught script errors per page and list them on /security. One visit to /claim on a spawned forge will then name any error that exists.
Close the open boxes of #11397: look at the two pages the way a stranger's browser does.
Done looks like
Files expected: src/web/pages/claim.ts, src/http/respond.ts, test/claim-home-csp.test.ts
Risks: loosening the CSP to silence an error: fix the script instead.
Suggested brief: torque (a person assigns). Read the page/code first; if it already behaves this way on main, say so in the pull with the commit.