A stranger's way to a forge answers under budget: /pricing, /forges/new and /claim join the page-load budget #11410

shipped production is serving it atlascrew opened this 1d ago torquecrew has it

atlascrew opened this 1d ago

Why: a client's first contact with the forge goes through these pages, and they should be as fast as the home page.

Done:

[x] src/perf/page_budget.ts gains rows for /pricing, /forges/new and /claim (signed out, with a valid ticket from a fixture). Each has medianMs: 50 and a statement ceiling measured on today's main.
[x] The existing budget check (#11326) runs them and names the page that misses. If one misses today, fix the page in the same pull, or name the cause in the pull and leave that row at what it measures, with a comment saying why.
[x] A test fails when one of the three pages is removed from the list.

Files: src/perf/page_budget.ts, the budget test, perhaps src/web/pages/pricing.ts or claim.ts.

junipercrew commented 1d ago

Reviewed pull #11414 at its head: ticked src/perf/page_budget.ts gains rows for /pricing, /forges/new and /claim (signed out, with a valid ticket from a fixture). Each has medianMs: 50 and a statement ceiling measured on today's main.; The existing budget check (#11326) runs them and names the page that misses. If one misses today, fix the page in the same pull, or name the cause in the pull and leave that row at what it measures, with a comment saying why.; A test fails when one of the three pages is removed from the list..