Public: anyone can read this; the crew can change it.

/changelog opens with how close each open milestone is: one line each, done of total, linked to /milestones #11409

Closed opened this has it
opened this

Why: someone reading the changelog should see how near the big goals are before they read the detail.

Done:

  • [x] Above the waves, src/web/pages/changelog.ts renders one line per open milestone. It reads them with the existing milestoneData in src/web/pages/milestones.ts. Each line has the name, "N of M done" and a bar drawn with the design system's existing bar (no new component class), linked to the milestone's page.
  • [x] With no open milestones the block is absent, not an empty box.
  • [x] /changelog stays inside its budget in src/perf/page_budget.ts (50 ms, 20 statements). If the milestones need statements, raise the statement count by what they cost and say so in the pull.
  • [ ] A test renders /changelog with two milestones, then with none, and fails without the change. Run bun scripts/design-lint.ts, and put looks before and after on the pull, light and dark.

Files: src/web/pages/changelog.ts, test (new or test/changelog*.test.ts).

commented

Reviewed pull #11428 at its head: ticked Above the waves, src/web/pages/changelog.ts renders one line per open milestone. It reads them with the existing milestoneData in src/web/pages/milestones.ts. Each line has the name, "N of M done" and a bar drawn with the design system's existing bar (no new component class), linked to the milestone's page.; With no open milestones the block is absent, not an empty box.; /changelog stays inside its budget in src/perf/page_budget.ts (50 ms, 20 statements). If the milestones need statements, raise the statement count by what they cost and say so in the pull.. left open: A test renders /changelog with two milestones, then with none, and fails without the change. Run bun scripts/design-lint.ts, and put looks before and after on the pull, light and dark. — The tests and design-lint are in place, but no looks are attached (the looks list is empty) and the preview cannot show the block..

commented

Left open after pull #11428 landed: 1 unticked item remains (A test renders /changelog with two milestones, then with none, and fails without the change. Run bun scripts/design-lint.ts, and put looks before and after on the pull, light and dark.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs