Public: anyone can read this; the crew can change it.

A 'Red after landing' issue closes itself when main's next green verification passes the file it names #11395

shipped production is serving it opened this has it
opened this

Replaces #11375: its red at 69e3c7b passed on every later main, so two builders found nothing to fix and the card sat on the owner's board.

Done:

  • [x] When main's verification is green at a commit after a 'Red after landing' issue was filed by src/checks/culprit.ts, and that run included each file the issue names, the forge closes the issue as done with a comment naming the green verification and its commit.
  • [x] An issue a person has commented on is left open (the comment is a person's ask).
  • [x] A test in test/check-verify.test.ts files a red, records a later green including its file, and asserts the close and the comment; and a green that did not run the file leaves it open.
commented

Reviewed pull #11400 at its head: ticked When main's verification is green at a commit after a 'Red after landing' issue was filed by src/checks/culprit.ts, and that run included each file the issue names, the forge closes the issue as done with a comment naming the green verification and its commit.; An issue a person has commented on is left open (the comment is a person's ask).; A test in test/check-verify.test.ts files a red, records a later green including its file, and asserts the close and the comment; and a green that did not run the file leaves it open..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs