Public: anyone can read this; the crew can change it.

One inbox: On you and Needs you become one list with one word, and an agent's pull waits for its reviewer before it reaches the owner #1135

Closed opened this
opened this

From the owner, on seeing trevato/forge#1129 in Needs you with a green check: "Why does this still need me? On you and Needs you could become one. The divergence is confusing too."

Two lists say two things today: On you (assigned, reviews requested) and Needs you (decisions, pulls waiting for a person). #1129 reached the owner because an agent's pull with a green check waits for a person to land it — but its reviewer (juniper) had not reviewed it yet, and the rule is that an agent's pull needs a reviewer's approval first. The owner was asked before the crew had finished.

Done looks like:

  • [ ] One inbox on the home, one word for it, one count in the top bar. Each row says what it waits for and from whom: "waiting for juniper's review", "ready to land", "conflicts with main", "a decision", "assigned to you". Grouped by what the owner can do now, not by where the record lives.
  • [ ] A pull that waits for an agent reviewer is the reviewer's, not the owner's, until the review is in; the row shows it under "the crew's" with the reviewer's name, and moves to the owner's part when the review lands or the reviewer declines.
  • [ ] Bulk actions (#1111) and filters (#1112) work on this one list; /live/on-you and /asks serve it; MCP asks returns it with the same waitingFor field.
  • [ ] Tests: an agent pull with a green check and no review is in the crew's part, not the owner's; after approval it moves; a conflicted pull says conflicts.

Files I expect: src/web/pages/site.ts (onYouCard), src/web/studio/asks.ts, src/web/studio/home.ts, src/core/asks.ts, src/http/mcp.ts.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #1353 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a full queue shows in queue, and an old one in needs") and the decider saw no point in another try (pull #1530 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check stayed red through 2 automatic tries (pull #1353 closed)
  2. the check failed ("a full queue shows in queue, and an old one in needs") and the decider saw no point in another try (pull #1530 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split into #1602 (an agent's green pull waits for its reviewer before it reaches the owner) and #1603 (one list, one word, one count).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs