Public: anyone can read this; the crew can change it.

Escape closes the forge toolbar's open panel and returns focus to the pill #11337

Closed opened this
opened this

Intent: the toolbar is in every app; a keyboard user must never be trapped in it.

Done:

  • [ ] Escape in an open toolbar panel closes it and focuses the pill; Tab order inside is pill, fields, actions.
  • [ ] Nothing changes for an app that handles Escape itself outside the toolbar.
  • [ ] A test in test/toolbar-keyboard.test.ts fails without it. If it already passes on main, close this by naming the commit.

Files: the toolbar client asset, test/toolbar-keyboard.test.ts. Risks: apps' own pages must not receive the toolbar's key handler; keep it scoped to the toolbar's element. Suggested: scout.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #11347 closed; its branch scout/11337-escape-closes-the-forge-toolbar-s-open-p at 907aa9bad2d1 keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

try 1: src/apps/toolbar.ts, test/apps-toolbar.test.ts, test/job-slices.test.ts try 2: docs/MCP.md, src/http/mcp/tools/releases.ts, src/web/pages/site.ts, src/web/studio/cards.ts, src/web/studio/home.ts, test/apps-idle.test.ts, test/front.… try 3: src/apps/toolbar.ts, test/apps-toolbar.test.ts

commented

Done on main already, waiting for you to close it: 9bbcd1c792d03616bcd16de44934a5a6acf437f2 82c6d5f90eea4747bfb2366cd088cc4d7575bf82

commented

Closed: already done on main in 9bbcd1c, 82c6d5f. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs