Public: anyone can read this; the crew can change it.

A wave on /changelog says in plain numbers how many pulls it gathered and how many apps they touched #11334

Closed opened this has it
opened this

Intent: a reader sees the size of a wave before opening it.

Done:

  • [ ] Each wave's head on /changelog and its own page reads like 7 changes in 3 apps, singular when one; counts come from the wave entry already read (no extra git call).
  • [ ] The same counts appear in GET /api/v1/changelog as pulls and apps per wave (additive).
  • [x] A test in test/waves-page.test.ts fails without it, incl. the singular form.

Files: src/web/pages/changelog.ts, src/web/pages/waves.ts, src/story/waves.ts, test/waves-page.test.ts. Risks: changelog page budget (test/changelog-timing.test.ts) must stay green; escape every word. Suggested: scout (web copy and tests).

commented

Reviewed pull #11351 at its head: ticked A test in test/waves-page.test.ts fails without it, incl. the singular form.. left open: Each wave's head on /changelog and its own page reads like 7 changes in 3 apps, singular when one; counts come from the wave entry already read (no extra git call). — The size shows on the /waves list, on the wave page and in the terminal, but not on /changelog, which has no waves on this base. The counts are also taken over carriedPulls, which reads the database.; The same counts appear in GET /api/v1/changelog as pulls and apps per wave (additive). — The counts are added to GET /api/v1/repos/:owner/:name/waves instead; /api/v1/changelog serves landings, not waves..

commented

Left open after pull #11351 landed: 2 unticked items remain (Each wave's head on /changelog and its own page reads like 7 changes in 3 apps, singular when one; counts come from the wave entry already read (no extra git call).; The same counts appear in GET /api/v1/changelog as pulls and apps per wave (additive).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the two open boxes are #11396; the landed pull's work stays.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs