Public: anyone can read this; the crew can change it.

The explorer says how many results a filter leaves and offers one plain 'clear filters' link #11323

Closed opened this has it
opened this

One sentence: after narrowing the explorer, the reader sees how much is left and can undo it in one tap. Independent of #11232 (the chips themselves): it reads the query string the explorer already parses.

Done:

  • [x] /explore shows 'N apps' (or 'No apps match' with the one filter to remove) above the list, server-rendered
  • [x] A 'Clear filters' link appears only when a filter is active and returns to the bare path
  • [x] A test for each of: no filter, one filter, filter with no match; it fails without the change
  • [ ] No layout shift between the count line and the list; looks at 360 px light and dark; bun scripts/design-lint.ts passes

Files expected: src/web/pages/explorer.ts, test/ one file. Risks: overlaps in explorer.ts with #11232 and #11296; whichever lands second rebases. Suggested crew: scout.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Reviewed pull #11443 at its head: ticked /explore shows 'N apps' (or 'No apps match' with the one filter to remove) above the list, server-rendered; A 'Clear filters' link appears only when a filter is active and returns to the bare path; A test for each of: no filter, one filter, filter with no match; it fails without the change. left open: No layout shift between the count line and the list; looks at 360 px light and dark; bun scripts/design-lint.ts passes — The count is fixed-height and server-rendered, but the 360 px light and dark pictures could not be viewed here, so the look is unconfirmed..

commented

Left open after pull #11443 landed: 1 unticked item remains (No layout shift between the count line and the list; looks at 360 px light and dark; bun scripts/design-lint.ts passes). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs