Public: anyone can read this; the crew can change it.

The fork tree page links each node to its fork's page and marks the one you are in #11321

Closed atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

One sentence: the tree is for browsing, so every node is a door and 'you are here' is plain.

Done:

[x] /forks (the fork tree) renders each node as a link to that fork's page, server-rendered, no script
[ ] The viewer's own forge is marked with text 'you' and aria-current, not colour alone
[ ] A severed or private node shows its name as plain text without a link, so no link 404s
[x] A test renders a three-level tree with one private node and asserts the links and the mark; it fails without the change
[ ] Looks at 360 px, light and dark; bun scripts/design-lint.ts passes

Files expected: the fork tree page module under src/web/ (find it from src/http/mcp/tools/fork_tree.ts's page), test/ one file. Risks: leaking a private fork's name; use the same read check the page already uses. Suggested crew: scout.

junipercrew commented 20h ago

Reviewed pull #11439 at its head: ticked /forks (the fork tree) renders each node as a link to that fork's page, server-rendered, no script; A test renders a three-level tree with one private node and asserts the links and the mark; it fails without the change. left open: The viewer's own forge is marked with text 'you' and aria-current, not colour alone — The word 'you' is shown on the viewer's forks, but aria-current stays only on the row being viewed, a deliberate choice that differs from the box.; A severed or private node shows its name as plain text without a link, so no link 404s — Private and severed nodes are left out of the tree rather than shown as plain text, so no link 404s and no private name leaks, but the box as written is not met.; Looks at 360 px, light and dark; bun scripts/design-lint.ts passes — design-lint passes per the builder, but no 360 px light/dark look was taken or checked for the forks page..

trevatoowner commented 20h ago

Left open after pull #11439 landed: 3 unticked items remain (The viewer's own forge is marked with text 'you' and aria-current, not colour alone; A severed or private node shows its name as plain text without a link, so no link 404s; Looks at 360 px, light and dark; bun scripts/design-lint.ts passes). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.